Skip to content

Don't create v4 projects for CSS files that don't look like v4 configs #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 5, 2025
Merged

Don't create v4 projects for CSS files that don't look like v4 configs #1164

merged 8 commits into from
Feb 5, 2025

Conversation

thecrypticace
Copy link
Contributor

@thecrypticace thecrypticace commented Feb 4, 2025 •
edited by RobinMalfait
Loading

Fixes #926

@thecrypticace
Copy link
Contributor Author

@RobinMalfait @philipp-spiess what do you think about this approach?

RobinMalfait
RobinMalfait reviewed Feb 4, 2025
View reviewed changes
@thecrypticace thecrypticace marked this pull request as ready for review February 4, 2025 17:45
@thecrypticace thecrypticace merged commit b9b40d5 into main Feb 5, 2025
@thecrypticace thecrypticace deleted the fix/skip-v3-css-files branch February 5, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipp-spiess philipp-spiess philipp-spiess approved these changes

@RobinMalfait RobinMalfait RobinMalfait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hovers and completions not showing in a v4 project
3 participants
@thecrypticace @philipp-spiess @RobinMalfait